CON-2198 uncomment availibility block in config #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horczech
added
the
Generator
horczech
commented
Sep 16, 2024
|
|
||
| #### Release strategy | ||
| #### CurrencyValueOldUpdateValue |
There was a problem hiding this comment.
I know about this problem, I mentioned on backend PR here
horczech
commented
Sep 16, 2024
operations/availabilityblocks.md
Outdated
|
|
||
| | Property | Type | Contract | Description | | ||
| | :-- | :-- | :-- | :-- | | ||
| | `Value` | [The strategy for automatic release of the availability block.](availabilityblocks.md#the-strategy-for-automatic-release-of-the-availability-block) | required | | |
There was a problem hiding this comment.
I know about the missing description and wrong title. I mentioned it on backend PR here
VBuben
reviewed
Sep 17, 2024
| * `Released` - The block deducts availability, but only for reservations assigned to the block before release. Remaining availability is returned back to general availability \(waitlist\). | ||
| * `Canceled` - The block does not deduct availability and cannot have reservations assigned \(waitlist\). | ||
| | `EnterpriseIds` | array of string | optional, max 1000 items | Unique identifiers of the Enterprises. If not specified, the operation returns data for all enterprises within scope of the Access Token. | | ||
| | `Extent` | [Availability block extent](availabilityblocks.md#availability-block-extent) | required | Extent of data to be returned, e.g. it is possible to specify that related service orders (for example reservations) are returned. | |
There was a problem hiding this comment.
I believe this one is not required and has default when it's not gonna return anything 😅 Verify it but I would make it reflect actual reality so to avoid confusion.
There was a problem hiding this comment.
Agreed, all extents are optional by default.
- remove extra Availability block state - improve ReleasedUtc description
| @@ -1,9 +1,9 @@ | |||
| <!-- AUTOMATICALLY GENERATED, DO NOT MODIFY --> | |||
| # Availability blocks | |||
|
|
|||
| ## Get all availability blocks | |||
|
|
|||
| > This feature is being actively developed, features and behavior of this operation may change at short notice. | |||
There was a problem hiding this comment.
Does this statement still apply? If it does, I think we should be using the normal Restricted! label (see other examples in the docs) for consistency. If not, then it should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mews.atlassian.net/browse/CON-2198: Migrate Availability Blocks page
Follow style guide
Style guide
Check during review