Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestAssured JWT annotation #426

Merged
merged 1 commit into from
Oct 22, 2024
Merged

RestAssured JWT annotation #426

merged 1 commit into from
Oct 22, 2024

Conversation

appiepollo14
Copy link
Collaborator

fixes #293

@appiepollo14
Copy link
Collaborator Author

@KyleAure ready for your approval

@appiepollo14
Copy link
Collaborator Author

@KyleAure when do you find the time to take a look at the PR's and comments?

@KyleAure
Copy link
Collaborator

KyleAure commented Jan 3, 2024

Still a few unresolved issues. @appiepollo14

@appiepollo14
Copy link
Collaborator Author

Done!

@appiepollo14
Copy link
Collaborator Author

@KyleAure Leggooo

@appiepollo14
Copy link
Collaborator Author

hi @KyleAure hope you're alright.. there is not much going on in the repo.. Can we pick up the pace again?

@appiepollo14
Copy link
Collaborator Author

@KyleAure Still no time for this one?

@KyleAure
Copy link
Collaborator

@appiepollo14 I am still interested in integrating this feature. There are some existing review comments that still need to be resolved and some merge conflicts.

@appiepollo14
Copy link
Collaborator Author

Which comments I only see resolved ones. Will do a rebase.

@KyleAure
Copy link
Collaborator

KyleAure commented Oct 22, 2024 •
edited
Loading

I un-marked the comments that were marked as resolved with no resolution present and added more details.

@appiepollo14 appiepollo14 force-pushed the feature/rest-assured-jwt branch 2 times, most recently from f746ef2 to eee874b Compare October 22, 2024 17:33
@appiepollo14
fixes MicroShed#293
6f90fb4 
Signed-off-by: appiepollo14 <[email protected]>
@appiepollo14
Copy link
Collaborator Author

I un-marked the comments that were marked as resolved with no resolution present and added more details.

Resolved al un-marked comments. Please have a final check!

@KyleAure KyleAure merged commit f9ecc1c into MicroShed:main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAure KyleAure KyleAure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing JWT endpoint with RESTassured
2 participants
@appiepollo14 @KyleAure