Feature/w2h #17
Merged
Feature/w2h #17
+244
−956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a point plot and w2h score
pvengat
requested changes
Sep 19, 2025
lib/diag.c
Outdated
| printf("Eye Left %d\n", out.eye_left); | ||
| printf("Eye Right %d\n", out.eye_right); | ||
| printf("Eye top @X1 %d\n", out.eye_top_x1); | ||
| printf("Eye Bottom @X1 %d\n", out.eye_bottom_x1); |
There was a problem hiding this comment.
resolved
inc/switchtec/diag.h
Outdated
| int32_t eye_left; | ||
| int32_t eye_right; | ||
| int32_t eye_top_x1; | ||
| int32_t eye_bottom_x1; |
There was a problem hiding this comment.
Corrected
cli/graph.c
Outdated
| plot_point(X_LAYOUT_SHIFT + Y_PRINT_OFFSET, data[2] + X_PRINT_OFFSET); // (30,15) | ||
| plot_point(X_LAYOUT_SHIFT + Y_PRINT_OFFSET, data[3] + X_PRINT_OFFSET); // (35,18) | ||
| if(plot_6p_points == true) | ||
| { |
There was a problem hiding this comment.
over all the places, braces not used in this way
There was a problem hiding this comment.
corrected and maintained common way
cli/graph.c
Outdated
| if(plot_6p_points == true) | ||
| { | ||
| data[4] = data[4] + Y_LAYOUT_SHIFT; | ||
| data[5] = data[5] + Y_LAYOUT_SHIFT; |
There was a problem hiding this comment.
corrected
cli/graph.c
Outdated
| } | ||
| else | ||
| { | ||
| plot_point(X_LAYOUT_SHIFT + Y_PRINT_OFFSET, data[2] + X_PRINT_OFFSET); |
There was a problem hiding this comment.
alignment and braces correction overall
There was a problem hiding this comment.
Resolved
vigneshraja123717
force-pushed
the
feature/w2h
branch
2 times, most recently
from
2792e88 to
60d465d
Compare
vigneshraja123717
force-pushed
the
feature/w2h
branch
from
60d465d to
aa46416
Compare
vigneshraja123717
force-pushed
the
feature/w2h
branch
from
aa46416 to
da8fafe
Compare
vigneshraja123717
force-pushed
the
feature/w2h
branch
from
2c5e8d0 to
2bff74b
Compare
pvengat
approved these changes
Sep 19, 2025
cli/diag.c
Outdated
| int port, lane, gen; | ||
| char fname[100]; | ||
| FILE *f; | ||
| { |
lib/diag.c
Outdated
| else if(out.status == EOM_SUCCESS) { | ||
| printf("Eye Left %d\n", out.eye_left); | ||
| printf("Eye Right %d\n", out.eye_right); | ||
| printf("Eye top %d\n", out.eye_top_x1); |
cli/diag.c
Outdated
| if (!ret) { | ||
| w2h_score = calculate_w2h_score(&data_6p_out); | ||
| printf("W2H Score for Lane %d is %d\n", lane_id, w2h_score); | ||
| eye_plot_graph(eye_6p_data, true, w2h_score); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented 6p capture command to display w2h score in terminal and plot 6 data points