Skip to content

Corrected query syntax/description #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Conversation

finnigd
Copy link
Contributor

@finnigd finnigd commented Apr 9, 2025

Corrected the query syntax and description of one of the troubleshooting queries.

Pull request guidance

Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.

We also need your help in order to process your request as soon as possible:

  • We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

  • After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

Corrected the query syntax and description of one of the troubleshooting queries.
Copy link

@finnigd : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 718ac05:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/replication/sql-transaction-log-grows.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@sevend2
Copy link
Collaborator

sevend2 commented Apr 22, 2025

@PiJoCoder Could you help review this update and let me know your suggestion? Thanks.

@PiJoCoder
Copy link
Contributor

@PiJoCoder Could you help review this update and let me know your suggestion? Thanks.

@JamesFerebee for review

Copy link
Contributor

@JamesFerebee JamesFerebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me technically, thanks for the contribution.

We may want to update lines 84 and 97 to be updated from your_cdc_database to <your_cdc_database> to be consistent based on this latest change.

Copy link
Contributor

Learn Build status updates of commit 0142a06:

✅ Validation status: passed

File Status Preview URL Details
support/sql/database-engine/replication/sql-transaction-log-grows.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@sevend2 sevend2 merged commit 74f766d into MicrosoftDocs:main Apr 23, 2025
2 checks passed
@sevend2
Copy link
Collaborator

sevend2 commented Apr 23, 2025

Looks good to me technically, thanks for the contribution.

We may want to update lines 84 and 97 to be updated from your_cdc_database to <your_cdc_database> to be consistent based on this latest change.

Thanks for your review and I have made changes as your suggestion in the private PR: https://github.com/MicrosoftDocs/SupportArticles-docs-pr/pull/8778. Feel free to let me know if any further feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants