Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate getHostEnvironmentValue in "Site compatibility" #3388

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

victorhuangwq
Copy link
Contributor

@victorhuangwq victorhuangwq commented Feb 26, 2025

Rendered article sections for review:

AB#56446734

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a deprecation notice for the Edge-only function by documenting its planned removal in favor of the standardized User-Agent Client Hints API.

  • Introduces a new table row to warn about the deprecation of the non-standard API.
  • Provides a link to the UA Client Hints API documentation for further guidance.

Reviewed Changes

File Description
microsoft-edge/web-platform/site-impacting-changes.md Added a deprecation row for getHostEnvironmentValue to inform users of the upcoming change.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@mikehoffms mikehoffms added the cat: webplatform Web Platform-related content. label Feb 27, 2025
@mikehoffms mikehoffms changed the title Add Deprecation Notice of 'getHostEnvrionmentValue` Deprecate getHostEnvrionmentValue in "Site compatibility" Feb 27, 2025
@mikehoffms mikehoffms changed the title Deprecate getHostEnvrionmentValue in "Site compatibility" Deprecate getHostEnvironmentValue in "Site compatibility" Feb 27, 2025
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Writer

Copy link
Contributor Author

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Learn Build status updates of commit de8cf69:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/web-platform/site-impacting-changes.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit e624410 into main Feb 28, 2025
2 checks passed
@captainbrosset captainbrosset deleted the user/victorhuang/add-deprecating-gethostenv branch February 28, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webplatform Web Platform-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants