Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added google looker documentation #501

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

kenrickyap
Copy link

Google looker connector is currently in the process of being certified, as part of the certification process we needed to provided documentation.

@prmerger-automator prmerger-automator bot added the do-not-merge Don't merge this yet label Jan 11, 2024
Copy link
Contributor

Learn Build status updates of commit 23a5152:

⚠️ Validation status: warnings

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ⚠️Warning Details
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded

powerquery-docs/connectors/google-looker.md

  • Line 2, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
  • Line 2, Column 1: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
  • Line 12, Column 1: [Warning: file-not-found - See documentation] Invalid file link: './media/google-bigquery/Looker64.png'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit beb2c68:

⚠️ Validation status: warnings

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ⚠️Warning Details
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

powerquery-docs/connectors/google-looker.md

  • Line 2, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
  • Line 2, Column 1: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jan 11, 2024

@kenrickyap

Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)?

After the CLA is signed, someone can review your pull request. Thanks!

@Court72
Copy link
Contributor

Court72 commented Jan 11, 2024

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@JasonWHowell JasonWHowell added question Further information is requested waiting-for-feature-release Connector Related to a new connector article. labels Jan 16, 2024
@kenrickyap
Copy link
Author

Hi all, sorry for the delay, we are still trying to figure out which company should sign the CLA.

@kenrickyap
Copy link
Author

@microsoft-github-policy-service agree [company="Google"]

@kenrickyap
Copy link
Author

@microsoft-github-policy-service agree company=Google

Copy link
Contributor

@kenrickyap : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@kenrickyap
Copy link
Author

Hi @DougKlopfenstein, just wondering if you could provide an ETA for a review? Thanks!

@JasonWHowell
Copy link
Collaborator

JasonWHowell commented Apr 8, 2024

#assign:ptyx507x
#assign:jonburchel

Copy link
Contributor

Users ptyx507x are already assigned.

@kenrickyap
Copy link
Author

will be acting as the new POC of this PR

Copy link
Contributor

Learn Build status updates of commit 7475be0:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 7475be03ae1f8dc17bfd2a5da376984797f37ded in branch main of repository https://github.com/kenrickyap/powerquery-docs into branch main (commit bdf286aea2b4756ff95e87d9822ed3189f1c861b). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ptyx507x
Copy link
Contributor

@kenrickyap could you please confirm that this PR contains the correct files / documentation for your connector?

@JasonWHowell
Copy link
Collaborator

@DougKlopfenstein the index.md for connectors got conflicts due to the swich from :::image back to the old format. Do you want to fix that conflict here to prevent future issues?

Copy link

@lisameldridge lisameldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I suggested three small edits.

powerquery-docs/connectors/google-looker.md Outdated Show resolved Hide resolved
powerquery-docs/connectors/google-looker.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit f52a42b:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link
Contributor

Learn Build status updates of commit a80e21e:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link
Contributor

Learn Build status updates of commit 0115a10:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link

@lisameldridge lisameldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes; otherwise, approved.

powerquery-docs/connectors/google-looker.md Outdated Show resolved Hide resolved
powerquery-docs/connectors/google-looker.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit c53ccd7:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/navigator-view-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link
Contributor

Learn Build status updates of commit 793a78f:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/navigator-view-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link
Contributor

Learn Build status updates of commit ba663f4:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/navigator-view-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link
Contributor

Learn Build status updates of commit 5e6e1c0:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/navigator-view-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

@ptyx507x
Copy link
Contributor

#hold

Copy link
Contributor

Learn Build status updates of commit 4cfda27:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/navigator-view-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Copy link
Contributor

Learn Build status updates of commit b3db00b:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/connectors/google-looker.md ✅Succeeded
powerquery-docs/connectors/index.md ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/host-connection-filled-desktop.png ✅Succeeded
powerquery-docs/connectors/media/google-looker/navigator-view-desktop.png ✅Succeeded
powerquery-docs/connectors/media/index/looker-64.png ✅Succeeded
powerquery-docs/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).
Index File This PR contains a change to the index file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants