Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slash): reset index when out of bounds #1537

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sindras
Copy link
Contributor

@sindras sindras commented Oct 13, 2024

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Addressing issue reported in #1536

How did you test this change?

  • Storybook

Before: hover index was out of menu
https://github.com/user-attachments/assets/a3e21563-5749-4444-8476-50dc5e4abaf8

After: hover index reset to zero when out of bounds
https://github.com/user-attachments/assets/805f312a-5a96-4416-b480-f40bf103fcd5

Copy link

changeset-bot bot commented Oct 13, 2024

⚠️ No Changeset found

Latest commit: f1b3e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 8:10am

Copy link

nx-cloud bot commented Oct 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f1b3e83. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Saul-Mirone Saul-Mirone merged commit a1262cf into Milkdown:main Oct 14, 2024
4 checks passed
@sindras sindras deleted the fix_slash_index branch October 15, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants