fix: allow running in insecure context #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit a8e81d1.
☁️ Nx Cloud last updated this comment at |
Saul-Mirone
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current packages for inline and image blocks use crypto.randomuuid to generate UUID for useState but crypto.randomuuid is not available in non-HTTPS context. This means it cannot run in insecure context.
How did you test this change?
I ran the tests and it passed all tests (pnpm test). I also used the mono repo in my existing project and it solves the issue.
I ran the package in an insecure context and I no longer run into issues. I fixed the issue by including nanoid to generate random UUIDs instead of relying on crypto. It adds bloat but nanoid is reliable and is one of the smallest (if not the smallest) package.