[DEV] port shellcheck job #16595
Draft
[DEV] port shellcheck job #16595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge Release/3.0.3.1 to master
[Rosetta][3.0.3.1] use mina missing block guardian script instead of download missing blocks
Yojson's pretty printing creates a huge call stack using the built-in OCaml list iterators. Since we're only printing an array of objects, we can easily implement a tail-recursive version
…-memo-printing Check validity of memos from GraphQL before printing them
…n-ledger-printing Manually implement JSON array printing to avoid stack overflow
Without this, we will attempt to send more enqueued messages, but if the
stream has already failed then we've already decided to close it. This
prevents a cascade of error messages like
```
2025-02-08 15:09:17 UTC [Error] error sending message on stream "20": $error
error: {
"string": "only wrote 0 out of 15 bytes error: libp2p error: stream reset"
}
2025-02-08 15:09:17 UTC [Warn] RPC call error for "get_best_tip"
2025-02-08 15:09:17 UTC [Error] error sending message on stream "20": $error
error: { "string": "internal RPC error: unknown stream_idx" }
2025-02-08 15:09:17 UTC [Error] error sending message on stream "20": $error
error: { "string": "internal RPC error: unknown stream_idx" }
2025-02-08 15:09:17 UTC [Error] error sending message on stream "20": $error
error: { "string": "internal RPC error: unknown stream_idx" }
```
This avoids the potential for a call to `Pipe.close` elsewhere when we still really do want to process messages.
…am_idx Stop sending data on libp2p streams after the first error
…llcheck_for_scripts
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port #16369 to develop