Prioritize explicitly defined config files over magic config files loading

[joaosreis]

Reorder the loading of configuration files to ensure that explicitly specified files via command-line arguments or environment variables take precedence over magic config files, otherwise, these will never be picked up when magic config files exist.

For example, running mina daemon --config-file /mina/sandbox.json ... will result in this loading order:
["/var/lib/coda/config_46a78df1.json","/root/.mina-config/daemon.json","/mina/sandbox.json"]
By applying this fix, the loading order will change to:
["/mina/sandbox.json","/var/lib/coda/config_46a78df1.json","/root/.mina-config/daemon.json"]

[joaosreis]

!ci-build-me

[martyall]

So when this list of files gets processed into a configuration value, it will apply the head of the list as a base layer and for each subsequent file it will use the values in that file to override what it has found so far (ie its a left fold).

in your printed example of status quo, this is the order you would want if you expect your sandbox file to override something.

is there a particular field that you are finding that this is not happening for / something else weird is happening ?

[joaosreis]

@martyall ah, I missed that part where each layer will override the previous. Was it always the case or did this change recently?

The scenario where we noticed problems is when we want to completely disregard the built-in network configuration (e.g. when launching a test sandbox network). What would be the best way to employ this?

[martyall]

As a stop-gap, what happens if you just remove "/var/lib/coda/config_46a78df1.json" ? There are a few places where this file is searched for (depends on system and how you installed), but if you don't see it appear in this logged list then it's not being used.

@martyall ah, I missed that part where each layer will override the previous. Was it always the case or did this change recently?

AFAIK this was always the case for the mina daemon, but not uniform behavior across the entire cli. Can I ask what cli command you are executing ?

[mrmr1993]

@joaosreis it sounds like you may be running into this