[Zkapp Verfiication key cache] refactor mina_base: extract verification_key_wire and zkapp_basic mods #16631
+459
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/refactor_mina_base
branch
from
12f3465 to
bf77340
Compare
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed necessary refactoring for enabling verification keys cache in mina.
We want to introduce new module zkapp_vk_cache_tag on top of Verification_key_write struct in mina_base. It implements binable so this is perfect candidate for read/write operations agains lmdb. However, if we introduce cache tag project for Mina_base.Verification_key_wire we will introduce cyclic dependency issue. Therefore we need to extract Verification_key_wire struct as well as zkapp_basic (which Verification_key_wire depends on) to new modules.
This PR is not introducing anything new, it's just a refactoring