Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kimchi-bindings: use UnsafeCell #16648

Open
wants to merge 1 commit into
base: compatible
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Feb 20, 2025

Coming from 2ec9256

If we don't have this update, Rust complains when updating to 1.74.
To convince yourself, update rust-toolchain.toml in kimchi_bindings/stubs to 1.74, and see the error when building.

This is a first step to update Rust in Mina to newer versions.
Doing it gradually.

@dannywillems dannywillems requested a review from a team as a code owner February 20, 2025 13:55
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

!ci-nightly-me

@coveralls
Copy link

Coverage Status

coverage: 35.511% (-25.3%) from 60.809%
when pulling 2d3ea97 on dw/use-unsafe-cell-for-1.74
into bd767a0 on compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants