-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupling Daemon External Port from healthcheck script #16649
Open
SanabriaRusso
wants to merge
4
commits into
develop
Choose a base branch
from
pod-probes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!ci-build-me |
dkijania
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with small nit
|
||
function updateSyncStatusLabel() { | ||
status=$( | ||
curl --silent --show-error --header "Content-Type:application/json" -d'{ "query": "query { syncStatus } " }' localhost:3085/graphql | \ | ||
curl --silent --show-error \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: looks like there is a potential to introduce single function and inject query:
function sendQraphqlQuery() {
local __query="$1"
echo
curl --silent --show-error \
--header "Content-Type:application/json" \
-d'{ "query": "$__query" }' \
"localhost:${DAEMON_REST_PORT}/graphql"
}
and then
function updateSyncStatusLabel() {
sendQraphqlQuery "query { syncStatus} " | jq '.data.syncStatus' | sed 's/"//g''
}
etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
This PR avoids using a static port for reaching the daemon's graphql endpoint. It defines an global variable for all the Functions that inherits the value from the environment, or sets it to the previously used password otherwise (i.e., 3085).
Explain how you tested your changes:
I expect to produce an artifact and check the corresponding
readinessProbe
in a Kubernetes deployment completes successfully.UPDATE: Deployed a pod for
devnet
and confirmed two important things:SYNCED
.Checklist: