Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring of mina_block.ml and block_sink.ml #16653

Open
wants to merge 4 commits into
base: compatible
Choose a base branch
from

Conversation

georgeee
Copy link
Member

Step toward #16582

Explain your changes:

  • Replace Mina_block.to_yojson with Mina_block.to_logging_yojson
    • the new functions operates on headers, but pretends to dump the block-like json
  • Small refactoring of block_sink.ml (just syntax)

Explain how you tested your changes:

  • it compiles
  • no functionality is changed

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner February 21, 2025 09:07
@georgeee
Copy link
Member Author

!ci-build-me

@georgeee
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants