Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for "replace Root with Root_(hash, common)" #16655

Open
wants to merge 6 commits into
base: compatible
Choose a base branch
from

Conversation

glyh
Copy link

@glyh glyh commented Feb 21, 2025

This is a follow up of #16624, and companions #16656.

This testcase tried to obtain root hash from the database once, and try it again and time it. The second time should be fast(with in 1 second). The testcase should panic if that's not the case, otherwise it will print out some logs and the time it takes for the second round of query.

I've added the testcase to mina's CLI, here's how it should be ran

dune exec mina test-persistent-frontier  -- -f PATH_TO_PERSISTENT_FRONTIER_DB

Here's the document for mina test-persistent-frontier

tests for persistent frontier             

  mina test-persistent-frontier 

=== flags ===

  --frontier-db Path      to frontier DB this app is testing on
                          (alias: -f)
  [--no-root-compatible]  Do not perform hash query once to ensure the
                          compatibility with old frontier database
                          (alias: -r)
  [-help]                 print this help text and exit
                          (alias: -?)

Please merge this only after #16650 is merged as this is their superset.

@dkijania Do you mind help me getting this on the CI?

@glyh
Copy link
Author

glyh commented Feb 21, 2025

The patch this PR is aiming to test is merged. We could go on to review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants