Repository navigation
Keep preparing sandboxes through deployment changes - #977
Merged
SaladDay merged 5 commits intoNov 19, 2026
Merged
Conversation
SaladDay
deleted the
keep-preparing-sandboxes-through-deployment-changes
branch
November 19, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectingmark that could later turn a Deployment frame into an ownership error and end the node, and the node helper treats collecting a generation it never prepared (no local files) as a no-op instead of failing on every retention heartbeat.failed(Fail pending input when an archive expires its Environment #951 removed the idle fork).Known and deliberately not fixed in this PR (review findings, medium):
collectingafter a failed removal lets a generation Core already released be prepared and reported again, while the node protocol says a dropped generation is never prepared or used again.Test plan
go test -race: a failed collection leaves the generation usabledeploy/nodeunittest: collecting a never-prepared generation is a no-op; a bare lease without identity still fails loudlygo vet,make check-docsOpen in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.