Skip to content

[contribution-request]: landing path for the prepared branches in #322 #608

Open

Description

@Ralle1976

Request

A scoped contribution path for the branches prepared in #322, so they can be landed instead of sitting on a fork.

The blocker, stated precisely

Creating a pull request against this repository fails for my account (Ralle1976) before the request body is even inspected:

POST /repos/MiniMax-AI/minimax-code/pulls
→ 404 Not Found

The same request shape against my own fork returns 422 (request validation), so the refusal happens at the repository-permission step, not in the payload. gh pr create --dry-run reports success and is misleading; the real API call is what fails.

Two statements in the repository documentation point in different directions, and I would like to follow whichever one applies:

  • docs/maintainers.md:18 — "Code and documentation PRs are accepted only from repository collaborators. Opening an issue or having a proposal accepted does not grant collaborator access or permission to submit a PR."
  • docs/community/oncall.md:69 — "Submission of a fork PR does not require collaborator access. Access is a convenience for maintainers, not a precondition for contributing."

I am not asking to bypass the policy. I am asking which of the two documented paths applies to a contributor who already has prepared, reviewed and verified branches.

What I am asking for

Either of these is enough; the first is the smaller favour.

  1. Open the pull requests from my fork. The branches are one commit each on top of 3c21163 (v0.7.2), so a cherry-pick or a branch transfer is all that is needed. This is the path that already worked here: docs: fix download banners and clarify CLI data directories #178 was ported from a contributor's fork, and fix(bash): preserve Windows PowerShell native exit codes #304 carried the [Bug]: Windows PowerShell 5.1: failing commands report success - native exit codes are swallowed by the shell wrappers #297 fix with a Co-authored-by trailer.
  2. Grant collaborator access to Ralle1976, so I can open them myself.

What is ready

All three branches are rebuilt on the current main (3c21163, v0.7.2, 2026-11-04) and verified on a Windows 11 x64 host (Node 24.18.0, PowerShell 5.1, no Developer Mode). The point-by-point response to the review of 2026-09-23, including the gates that were run and the ones that were not, is in #322.

Branch Commit Scope
test/srt-macos-host-path-join dc356b3 Assertion derives the expected value from the fixture input
test/policy-facade-windows-fixtures 2cdc893 Fixture pins the simulated platform; no production change
test/symlink-privilege-gated-skip 21a8a1b Symlink-safety suites gated on the Windows symlink privilege

A fourth branch, fix/file-save-create (50bb168, 112452a), is described in #607 — I am still waiting for the answer there on whether that route is still mounted internally.

Scope of the request

This is a request for a landing path for the branches above, not for anything broader. If the answer is no, I will keep contributing as issues and analysis, which is what has worked so far.

Reference: #322.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions