MCC->Launchpad updates#89
Merged
Merged
Conversation
james-nesbitt
force-pushed
the
1.5.14-upgrade
branch
from
5fe3e20 to
1411c55
Compare
james-nesbitt
force-pushed
the
1.5.14-upgrade
branch
9 times, most recently
from
3348d2d to
673e3dc
Compare
- Move to the now public launchpad repo - update to schema 15 (noop change) - go mod updates - gha updates - golang releaser updates - golangci-lint updates NOTES - dropped terraform fmt from go generate to simplify build inv that fmt is for the examples Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
- mcr metadata might be missing, so we add it to the initial project. Signed-off-by: James Nesbitt <jnesbitt@mirantis.com>
james-nesbitt
force-pushed
the
1.5.14-upgrade
branch
from
673e3dc to
97d7b22
Compare
james-nesbitt
commented
Oct 24, 2025
Contributor
Author
james-nesbitt
left a comment
james-nesbitt
left a comment
There was a problem hiding this comment.
Note the following linting changes:
- a block variable declaration was replaced with a one-line
- some variable names were too short
- some function arguments were unused, so should be ignored
- some whitespacing
| } | ||
|
|
||
| func NewLaunchpadConfigResource() resource.Resource { | ||
| func NewLaunchpadConfigResource() resource.Resource { //nolint:ireturn |
Contributor
Author
There was a problem hiding this comment.
The function returns an interface so that it matches the interface for the resource
| } | ||
|
|
||
| cc := ls.ClusterConfig(diags) | ||
| cc := ls.ClusterConfig(ctx, diags) |
Contributor
Author
There was a problem hiding this comment.
clusterconfig was using context.Background(), but we have the TF context here, so we just pass it through now.
| ) | ||
|
|
||
| func launchpadSchema14() schema.Schema { | ||
| func launchpadSchema15() schema.Schema { //nolint:maintidx |
Contributor
Author
There was a problem hiding this comment.
The linter thinks that this function goes too deep. It does go deep, but it is much more readable in this form than it would be to break it out into sub-functions that reduce this depth. The value here is that the function very much maps to the structure of the data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue
< The JIRA or GitHub issue URL >