Potential fix for code scanning alert no. 5: Workflow does not contain permissions #1881
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/MixinNetwork/flutter-app/security/code-scanning/5
The optimal fix is to add an explicit
permissionsblock to thebuild-windowsjob, restricting its permissions to the minimum necessary. Since the job uploads artifacts and uses a third-party upload step gated on tags (presumably for release), the generally safe and best-practice baseline is to grant read-onlycontentspermissions, unless a specific step in the job demands more.From inspection, the job uploads artifacts with
actions/upload-artifact(which does not requirecontents: write) and usessvenstaro/upload-release-actiongated on tags (which utilizes therepo_tokensecret for uploading to releases; this generally requirescontents: write).Thus, if the tag upload is needed for this job,
contents: writeis safest and mirrors the permissions already set in similar jobs. However, for minimal exposure, consider the same as the other jobs:This block should be added directly under
build-windows:(i.e., after line 276), before thesteps:block.Suggested fixes powered by Copilot Autofix. Review carefully before merging.