Skip to content

Add field city in station_information #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Nov 8, 2024

What problem does your proposal solve?

Currently, gbfs supports declaring street/cross_street/post_code of a rental station in station_information, but not city (see this slack discussion).

What is the proposal?

Add OPTIONAL field city to station_information.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

station_information

Other options considered

The concept of regions could be used to provide information on the city/political jurisdiction a station is located in, but that might conflict with usage for other zoning schemes, like neighborhoods or economic zones, as stated in the spec. In addition, I'm only aware of a few providers which use regions.

@richfab
Copy link
Contributor

richfab commented Nov 11, 2024

Thank you @hbruch for raising this issue and opening a PR 🙏

It seems like a good idea to be able to indicate the city where the station is located.

A vote will be opened 7 days after the PR was created as per the governance.

@richfab richfab added the v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass label Nov 11, 2024
@richfab
Copy link
Contributor

richfab commented Nov 18, 2024

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Thursday, November 28, 2024.
Please vote for or against the proposal, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

@cmonagle
Copy link
Contributor

+1 from Transit.

@futuretap
Copy link
Contributor

+1 from Where To? / FutureTap.

@tobsesHub
Copy link
Contributor

+1 from Raumobil.

@testower
Copy link
Contributor

+1 from Entur

@morten-skelmose
Copy link

+1 from VOI

@richfab
Copy link
Contributor

richfab commented Dec 3, 2024

I missed the 2 day announcement last week, so here it is.

💁 Voting on this PR closes in 2 calendar days.
Please vote for or against the proposal before 11:59PM UTC on Thursday, December 5, 2024, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

@richfab
Copy link
Contributor

richfab commented Dec 6, 2024

This vote has now closed, and it passes!

Votes in favor:

  • Transit (consumer)
  • Where To? / FutureTap (consumer)
  • Raumobil (consumer)
  • Entur (producer)
  • Voi (producer)

There were no votes against.

This change will be part of the next MINOR release, planned in May 2025, as per the version release cycle in the governance.

Thank you for your involvement in the GBFS spec 🙏

@tdelmas
Copy link
Contributor

tdelmas commented May 26, 2025

@richfab Just a reminder that the vote passed, so it should be included in the next release

@richfab
Copy link
Contributor

richfab commented May 26, 2025

Thanks, @tdelmas. This is planned to be included in the Release Candidate coming out this week.

@richfab richfab removed the stale label May 26, 2025
@richfab richfab reopened this May 27, 2025
@richfab richfab changed the base branch from master to release/v3.1-RC2 May 27, 2025 15:54
@richfab richfab merged commit 7461a0e into MobilityData:release/v3.1-RC2 May 27, 2025
1 check passed
@richfab richfab mentioned this pull request May 27, 2025
richfab added a commit that referenced this pull request May 28, 2025
* Add field city in station_information (#704)

* Prepare to merge 'City in station_information' into master

* Future availability by vehicle (#726)

* New vehicle_availability endpoint

* Update description to match id in vehicle_status

* Add pricing_plan_id and vehicle_equipment

* Make station_id conditionnally required

* Make station_id REQUIRED

* Add fare capping definition and example (#745)

* Prepare v3.1-RC2 release

---------

Co-authored-by: Holger Bruch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.1-RC2 Candidate change for v3.1 (minor release) - 2nd pass Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants