More robust gltf buffer memory views#145
Open
BlurryRoots wants to merge 1 commit into
Open
Conversation
introducing memory holes may corrupt contiguous space triggering errors like: BufferError: memoryview: underlying buffer is not C-contiguous
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the byteStride attribute is an element-level stride, not a byte-level slice step.
If we apply it as memoryview[::stride] it produces a non-C-contiguous view that will be rejected by struct.iter_unpack.
By introducing a get_buffer_stride method and using it with the calculated element_size depending on the scalar/vector size we can create a contiguous buffer from interleaved views.
Tested with provided pytests and their respective models.
Additionally tested with this (arguably cute) turtle https://sketchfab.com/3d-models/patsy-the-turtle-142e5d430b214ceba8510e47452bd910
Thanks for this nice loader.