-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BaseDocument._from_son() deepcopy failed with compiled regex #2438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @StoneMoe , thanks for your contribution. It looks great, I only have a minor few comments. Please check the comments and let me know if there are additional questions.
Hi, thanks for the reviewing, I added more tests and changed approach for this fix based on that. but there are some question might need more discussion:
|
sorry I lost track of this. I tested the initial issues on latest master and it's not failing anymore so I guess something got merged since this PR got created. I'm including the test cases in #2865 to avoid regression but I'm closing this one as I prefer to avoid too much hacks on deepcopy internals unless absolutly necessary |
Fix for issue #2429