Add test cases for pmd#1592

Monits · Mar 31, 2024 · 86328b7 · 86328b7
1 parent a47a301
commit 86328b7
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 0 deletions.
diff --git a/.../sourceforge/pmd/lang/java/rule/bestpractices/JUnit4TestShouldUseAfterAnnotationTest.java b/.../sourceforge/pmd/lang/java/rule/bestpractices/JUnit4TestShouldUseAfterAnnotationTest.java
@@ -4,8 +4,22 @@
 
 package net.sourceforge.pmd.lang.java.rule.bestpractices;
 
+import org.junit.After;
+import org.junit.Before;
+
 import net.sourceforge.pmd.test.PmdRuleTst;
 
 class JUnit4TestShouldUseAfterAnnotationTest extends PmdRuleTst {
     // no additional unit tests
+
+    public static class BaseTest {
+        @Before
+        public void setUp() {
+            // A setup code
+        }
+        @After
+        public void tearDown() {
+            // A tear down code
+        }
+    }
 }
diff --git a/...sourceforge/pmd/lang/java/rule/bestpractices/JUnit4TestShouldUseBeforeAnnotationTest.java b/...sourceforge/pmd/lang/java/rule/bestpractices/JUnit4TestShouldUseBeforeAnnotationTest.java
@@ -4,8 +4,22 @@
 
 package net.sourceforge.pmd.lang.java.rule.bestpractices;
 
+import org.junit.After;
+import org.junit.Before;
+
 import net.sourceforge.pmd.test.PmdRuleTst;
 
 class JUnit4TestShouldUseBeforeAnnotationTest extends PmdRuleTst {
     // no additional unit tests
+
+    public static class BaseTest {
+        @Before
+        public void setUp() {
+            // A setup code
+        }
+        @After
+        public void tearDown() {
+            // A tear down code
+        }
+    }
 }
diff --git a/...t/sourceforge/pmd/lang/java/rule/bestpractices/xml/JUnit4TestShouldUseAfterAnnotation.xml b/...t/sourceforge/pmd/lang/java/rule/bestpractices/xml/JUnit4TestShouldUseAfterAnnotation.xml
@@ -131,4 +131,24 @@ public class Foo {
             }
             ]]></code>
     </test-code>
+
+    <test-code>
+        <description>[java] JUnit4TestShouldUseBeforeAnnotation false positive when overriding setUp #1592</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import net.sourceforge.pmd.lang.java.rule.bestpractices.JUnit4TestShouldUseBeforeAnnotationTest.BaseTest;
+
+public class AReallyCoolFeatureTest extends BaseTest {
+    @Override
+    public void setUp() {
+        super.setUp();
+    }
+
+    @Override
+    public void tearDown() {
+        super.tearDown();
+    }
+}
+        ]]></code>
+    </test-code>
 </test-data>
diff --git a/.../sourceforge/pmd/lang/java/rule/bestpractices/xml/JUnit4TestShouldUseBeforeAnnotation.xml b/.../sourceforge/pmd/lang/java/rule/bestpractices/xml/JUnit4TestShouldUseBeforeAnnotation.xml
@@ -153,4 +153,24 @@ public class Foo {
             }
             ]]></code>
     </test-code>
+
+    <test-code>
+        <description>[java] JUnit4TestShouldUseBeforeAnnotation false positive when overriding setUp #1592</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import net.sourceforge.pmd.lang.java.rule.bestpractices.JUnit4TestShouldUseBeforeAnnotationTest.BaseTest;
+
+public class AReallyCoolFeatureTest extends BaseTest {
+    @Override
+    public void setUp() {
+        super.setUp();
+    }
+
+    @Override
+    public void tearDown() {
+        super.tearDown();
+    }
+}
+        ]]></code>
+    </test-code>
 </test-data>