Optimize bot pathfinding limits and fix typos - #342
Open
SilliconeMochi wants to merge 1 commit into
Open
Conversation
Reduce AStar distance parameters for all bots to improve pathfinding performance. Cleanbot search range reduced from 7 to 5. Fix beacon/beakon spelling inconsistencies in comments and code. AStar function is unable to use maximum distances over 30 anyways.
Collaborator
Test merge deployment history:Test Merge Deployed @ 08/22/2026 01:34:02 +00:00:Server InstanceMonkeris Merged Bymycah RevisionOrigin: e493fd7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Reduce AStar distance parameters for all bots to improve pathfinding performance. Cleanbot search range reduced from 7 to 5. Fix beacon/beakon spelling inconsistencies in comments and code. AStar function is unable to use maximum distances over 30 anyways.
Why It's Good For The Game
Simple changes to the bot pathfinding limits like the roomba. The AStar pathfinding function has a limit that doesn't throw a warning or information flag. Until a more complete rewrite can be done to the algorithm implementation this should help shore up performance issues even slightly.
Testing
Minor upload error forgot to include testing description.
Testing included A/B testing on a local server.
5 tests of each type were run.
Control
Change made in near round start conditions
Control + mob deletion then spawning of roombas
Change + mob deletion followed by spawning of roombas
The change had minimal impact below 10 roombas but had a measurable 3 ms reduction - this needs additional testing with someone who knows how to set the round init seed
Above 10 roombas there was a difference starting with a decrease of 10ms and maintained gradual lowering.
Additional Notes
Outliers in round start testing were discarded and then rerun.
Control had ranges from 180ms to 74ms, was nominally ~110ms
Change had ranges from 178 to 83, was nominally ~107ms
Changelog
🆑
tweak: reduced mulebot, cleanbot, roomba, farmbot, medbot, and secbot pathfinding range.