Skip to content

Optimize bot pathfinding limits and fix typos - #342

Open
SilliconeMochi wants to merge 1 commit into
Monkestation:masterfrom
SilliconeMochi:master
Open

Optimize bot pathfinding limits and fix typos#342
SilliconeMochi wants to merge 1 commit into
Monkestation:masterfrom
SilliconeMochi:master

Conversation

@SilliconeMochi

@SilliconeMochi SilliconeMochi commented Aug 10, 2026

Copy link
Copy Markdown

About The Pull Request

Reduce AStar distance parameters for all bots to improve pathfinding performance. Cleanbot search range reduced from 7 to 5. Fix beacon/beakon spelling inconsistencies in comments and code. AStar function is unable to use maximum distances over 30 anyways.

Why It's Good For The Game

Simple changes to the bot pathfinding limits like the roomba. The AStar pathfinding function has a limit that doesn't throw a warning or information flag. Until a more complete rewrite can be done to the algorithm implementation this should help shore up performance issues even slightly.

Testing

Minor upload error forgot to include testing description.
Testing included A/B testing on a local server.
5 tests of each type were run.
Control
Change made in near round start conditions
Control + mob deletion then spawning of roombas
Change + mob deletion followed by spawning of roombas

The change had minimal impact below 10 roombas but had a measurable 3 ms reduction - this needs additional testing with someone who knows how to set the round init seed
Above 10 roombas there was a difference starting with a decrease of 10ms and maintained gradual lowering.

Additional Notes
Outliers in round start testing were discarded and then rerun.
Control had ranges from 180ms to 74ms, was nominally ~110ms
Change had ranges from 178 to 83, was nominally ~107ms

Changelog

🆑
tweak: reduced mulebot, cleanbot, roomba, farmbot, medbot, and secbot pathfinding range.

Reduce AStar distance parameters for all bots to improve pathfinding performance. Cleanbot search range reduced from 7 to 5. Fix beacon/beakon spelling inconsistencies in comments and code.
AStar function is unable to use maximum distances over 30 anyways.
@ChiefMonkengineer

ChiefMonkengineer commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Test merge deployment history:

Test Merge Deployed @ 08/22/2026 01:34:02 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: e493fd7
Pull Request: e438c74
Server: 7b3c89670709901b8c335d67dbbb5b608199097f

Test Merge Updated @ 08/22/2026 15:57:04 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 328df9e
Pull Request: e438c74
Server: 37859a9b664cedba6d164ed5fd29679df2948a12

Test Merge Updated @ 08/23/2026 00:28:46 +00:00:
Server Instance

Monkeris

Merged By

mycah

Revision

Origin: 328df9e
Pull Request: e438c74
Server: cb30f9468c275a7439a40986a21613da97370daa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants