vicissitude nerf

[Wolf-751]

About The Pull Request

This pr is to address the powerful instant deletion ability of bone crafting from the discipline of Vicissitude, it is a powerful skill that had nothing but a cost of blood to instantly round remove players in soft crit without any control factor or downsides, thus being able to be used in the middle of combat when downing someone to instantly round remove them.

Why It's Good For The Game

Bone crafting is a extremely useful tool, but currently it has gained quite abit of power in a fight due to it being able to delete someone instantly when they are just in merely soft crit, this PR is to address this by making it so bone crafting not only fully requires a person to be dead, even torpor is not enough, the person has to be in a state of full death to allow bone crafting to take place. I have also added in a do after action that takes ten seconds for it to complete before the corpse is deleted to allow it to not be spammed rapidly on dead corpses and to give counter play to the bone craft user.

Changelog

Modified bone crafting to not be an instant critical health downstate win, the person has to be in a full death state.
Added a do_after to bone crafting, requiring a set amount of time of action to stop combat exploiting when deleting a target.

🆑
balance: rebalanced bone crafting, no longer an instant win button on soft critical targets
balance: Bone crafting requires a do after of 10 seconds before it casts, it can be interrupted before that by pulling the body away or pushing or pulling the bone crafter.

/:cl:

[chazzyjazzy]

minor nits then good to go

[TheTrueSilverRat]

Hey I just want to ask as an independent checker.
Doesn't return false mean it cuts out the else statement due to exiting early. making it so viss 3 can't be used to attack people anymore? just checking if that was tested already

[chazzyjazzy]

Hey I just want to ask as an independent checker. Doesn't return false mean it cuts out the else statement due to exiting early. making it so viss 3 can't be used to attack people anymore? just checking if that was tested already

note the indentation and the if-else chain from if(target.stat == DEAD) and the accompanying else. his check there is safety after the do_after to make sure the target is actually dead before gibbing the organs (maybe they were healed during the 10 sec windup?)

if the target is not dead, it doesn't proceed into if(target.stat == DEAD) and thus proceeds to the else further on - which deals the damage.