The Gangening, New Drug Trafficking Gang in San Fang - #85
The Gangening, New Drug Trafficking Gang in San Fang#85sylvia-from-fulp-station wants to merge 40 commits into
Conversation
type shit
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
|
This is just Triad 😔 |
The Triad is just one single gang. A different, "native" gang of primarily humans to oppose and rival them would be a nice addition. I think two non-supernatural gangs is a good number. |
|
The drug dealing idea is peak, much more immersive and it adds a bit of risk that just isnt there when all you have to do is get a shitton of weed in plant bags and sell them at the black market. (Also a lot of rp potential having dealers out in the streets and would give gangs a reason to fight over territory) |
I guess we should only have one group of vampires then, they all do the same thing? :P |
| if(istype(tool, /obj/item/stack)) | ||
| var/obj/item/stack/stack_item = tool | ||
| stack_multiplier = stack_item.amount | ||
| var/sale_price = round(selling_comp.cost * stack_multiplier * drug_price * (success_count > 0 ? success_count : NPC_DRUG_SALE_BOTCH_PENALTY)) |
There was a problem hiding this comment.
lol - this is gonna be nuts. we will have to balance this. keep for now.
There was a problem hiding this comment.
it uses the same value as black market so if that's nerfed this will be nerfed too
| if(!fleeing_from) | ||
| realistic_say(pick(socialrole?.drug_purchase_phrases)) | ||
|
|
||
| SEND_SIGNAL(SSdcs, COMSIG_GLOB_REPORT_CRIME, CRIME_DRUG_SALE, get_turf(src)) |
There was a problem hiding this comment.
sidenote - pretty sure the crime always gets 'reported' even no matter if there are no witnesses. have to check tho.
There was a problem hiding this comment.
this only runs if a cop sees it (or should)
| job_flags = CITY_JOB_FLAGS | ||
| outfit = /datum/outfit/job/vampire/gang | ||
| allowed_splats = list(SPLAT_NONE) | ||
| minimum_masquerade = 5 // nobody is gonna start a gang when theres swat in the city |
There was a problem hiding this comment.
thats not what this does. this check's the player's masquerade. for example - you can't join camarilla roles as a masquerade violator. this is because the system was persistent, but it broke, we just havent fixed it, and to be honest i don't plan to as i feel it doesn't fit CG
There was a problem hiding this comment.
dude if masquerade was persistent i'd be genuinely cooked
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
ok so - you've got your work cut out for you, and some design decisions to make.
many are saying this is de-racialized Chinese Triad from #31. this is an extremely valid point that you should dearly consider. as a matter of fact - i would say that 60% of this PR is useless with the Triad in perspective - not only is the Triad more setting-appropriate and flavorful (even with the obviously racial overtones, tho the faction's name should be changed from 'Chinese Triad' so that it isn't... explicitly... racial... and perhaps allowing people to play, for example Russian Triads) but it also has a much more logical base of operations - on both Oakland and San Francisco they're located in map-specific HQs in Chinatown next to the poorest part of the map, not to mention that they have guns and weed planters mapped in already for them
secondly - this entire PR is demodularized. we follow modularization protocol here which you can read at modular_darkpack/readme.md. HOWEVER this is not super necessary if you either 1.) open this PR on upstream (which is easy you just go to the secondcity repo and open this identical PR there) or tell me you wanna upstream it and i'll do it for u.
LMK what you think about my review and comments and if u need any help LMK - im willing to work on this too
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
…le.dm Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
I think you're also majorly overlooking how busted they're mapping these guys with their setup compared to literally any other faction in the game. And how much map real estate their base is getting. |
i think you need to get a job you are welcome to post constructive criticism but if you are just going to assume that chaz is blind and cant look at the image in the PR body i would like you stop commenting on my PR |
|
Please add some sort of streetwise linked option to try and see if an npc is a cop or gangster. |
keep them the same numbers as the triad |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
9 participants
About The Pull Request
This PR adds a gang faction with four jobs, similar to the triad but more numerous, has its own gimmick content and with its own base east of Giovanni mansion.
Selling weeds to NPCs
Along with the gang it adds the ability to sell weed to NPCs in the game, which is the main aim of the newly added street gang. The pay out is similar to the black market and it puts the skill "Streetwise" to use by adding level of it into calculation along with the NPCs income level (most giving 0.75 or 0.5, business NPCSs give 2x.).
If you try to sell weed to cops they will aggro you and start shooting. If a cop is present while the drug sale takes place, an alert will also be played in the police radio with the location. Newly added Criminal NPCs will also aggro if you try selling to them so be careful.
In addition to these since its expected to have more police NPC shootouts, now the other NPCs in the area will run away from the shooting location to add more immersion.
drug.dealing.mp4
Why It's Good For The Game
There is a lack of interesting jobs for humans to pick that aren't directly involved in either hunting or policing the supernatural. This also means that police jobs are mostly dealing with supernatural criminals, which isn't the most fun.
The overall goal of the PR was to add a fun job for humans to do, more stuff for police to do that isn't hunting vampires and werewolves, and make selling drugs more interesting. It also gives a use to putting dots into the streetwise skill.
Changelog
🆑 Sylvia & munchyi
map: Adds gang hideout to san fang
add: Adds gang faction, jobs, area, keys, outfits.
add: You can attempt to deal drugs to any human npc. some will accept at different rates and a different amount of times.
add: Police and Bandit NPCS will aggro based on drug trafficking; while regular NPCS will flee from this.
/:cl: