Set init value for access modifiers in symbol builders correctly #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SymbolBuilderDecorator contains instructions to set an initializing value for the access modifier attribute in generated symbol builders:
However, no init value is generated for the access modifier.
The problem is the following:
List<ASTCDAttribute> defaultAttrs = createSymbolAttributes(symbolClass);decoratedSymbolClassif the current symbol does not inherit it from another symbol that is extended:decoratedSymbolClass.addAllCDMembers(defaultAttrs);builderDecoratoris applied to thedecoratedSymbolClassin order to create a new ASTCDClass object namedsymbolBuilderwhich is consequently used:ASTCDClass symbolBuilder = builderDecorator.decorate(decoratedSymbolClass);builderDecoratordeepClones all attributes of the original CDClassaccessModifierattribute has a differerent object identity. While we registered the template-replacement for "no initial value" toALL_INCLUSIONon the original ASTCDAttribute, the template replacement map does not contain an entry for the new ASTCDAttribute. Hence, cd2java's default "no initial value" template is applied.Hence, template replacements have to be transferred to during the decoration of the
BuilderDecorator, or they have to be registered after the cloning. I did the latter in this merge request. This way, I added the replacement in the same way like it is already done for thebuild-Method in the SymbolBuilderDecorator.