Modify JavaLight CoCos for improved JavaModifier extensions #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cocos now work independent of completed symboltable * cocos now work as a whitelist for allowed modifiers instead of prohibiting the use of some. This way it supports adding new modifiers and require active modifications if those new modifiers are intended to be used.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This pull request revises all JavaLight CoCos in which the validity of JavaModifiers in constructors and methods is checked. A CoCo for checking the validity of JavaModifiers for methods is also added.
Why:
While Java distinguishes between different types of modifiers (such as: ClassModifier, MethodModifier etc), in JavaLight these are combined as JavaModifiers. For this reason, several things must be taken into account.
Due to this combination, CoCos should be implemented in such a way that they only allow permitted modifiers, while everything else is forbidden. If a modifier is added, this initially has no effect. Only by explicitly adapting CoCos (whitelisting) is its use finally permitted.