Refactor JavaModifiers #181
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to adapt
JavaModifiersinMCCommonStatements.Currently, an enumeration is used to represent
JavaModifiers. Internally, this ensures that constants are generated inASTConstantsMCCommonStatements, which can be read from aJavaModifierusing thegetModifier()method.This refactoring replaces the enumeration with a
JavaModifierinterface. To ensure conservative refactoring, the interface is given agetModifier()method. The individual modifiers are moved to separate production rules. Finally, thegetModifier()methods are implemented using the TOP mechanism, which continues to return the generated constants.Why:
The current implementation has several disadvantages in terms of extensibility, as it is not possible to extend the enumeration.
Specific problem cases (from JavaDSL):
sealedandnon-sealedshould therefore be introduced in JavaDSL instead ofMCCommonStatementsto prevent impacts on other languages.Finally, this adjustment will also allow for additional features in the future, such as linking the access modifier to the existing infrastructure for access modifiers, which would enable simpler visibility checks, for example.