Skip to content

Backport trafo optimization #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jra-se wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

Backport trafo optimization #201

jra-se wants to merge 24 commits into from

Conversation

@jra-se
Copy link
Contributor

@jra-se jra-se commented Oct 30, 2025

Backport optimizations for generated DSTL pattern matching, previously implemented in the trafo interpreter:

  • replace candidate ArrayLists with custom List implementation (sliding window to prevent excessive removals and constructions)
  • optimize parent lookup
  • optimize search plans by considering subtree relationships

jra-se added 13 commits September 11, 2025 10:06
@jra-se
use LinkedList instead of ArrayList for temporary candidate lists
0e258b3 
we remove the first element all the time and that raises the runtime significantly
@jra-se
use LinkedList instead of ArrayList for temporary candidate lists
9cb3ff2 
we remove the first element all the time and that raises the runtime significantly
@jra-se
use comments to store parents instead of hashmap
f9f63f2
@jra-se
use FastLookupList to prevent List copies
57f4426
@jra-se
add searchplan optimization
5f4e694
@jra-se
add missing candidate resets
4a8f21b
@jra-se
deepClone on move: monticore/monticore#4671
431e314
@jra-se
add dirty flag to the search graph to prevent unnecessary traversals …
9fd4c08 
…and initialisations
@jra-se
add error code
5734b6a
@jra-se
add option to disable search plan optimization
b4b48e7
@jra-se
add todo
4bc3cc3
@jra-se
Merge branch 'dev' into backport-trafo-optimization
c11815a
@jra-se
Merge branch 'refs/heads/dev' into backport-trafo-optimization
d20dda5
@jra-se jra-se requested a review from luepges October 30, 2025 14:10
@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

❌ Changes break the MontiVerse

Project Status
cd4analysis ❌
details
Project Status
montiarc ❔
umlp ❔
sd ❔
montifun ❔
fd ❔
automaton ❔
sc ❔
guidsl ❔
artifacts ❔
ocl ❔
od ❔
ucd ✅
langexperiments ✅
json ✅
xml ✅
cd2gui ❔
mlc ✅
cd4analysis ❌
monticore_basic ✅
class2mc ⏩

The MontiVerse is a collection of (internal and public) language projects.

@luepges luepges marked this pull request as draft November 24, 2025 14:35
@jra-se jra-se mentioned this pull request Dec 16, 2025
Open
@jra-se jra-se marked this pull request as ready for review December 17, 2025 08:52
@jra-se jra-se requested a review from luepges December 17, 2025 08:55
luepges
luepges approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@luepges luepges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ädnern wir die CD Tests vorher,
sodass die Reihenfolge egal ist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luepges luepges luepges approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jra-se @luepges