Catch exceptions in main #222
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SE-FDr
force-pushed
the
catchExceptionsInMain
branch
from
3cc9b98 to
1fd8b85
Compare
SE-FDr
force-pushed
the
catchExceptionsInMain
branch
from
1fd8b85 to
7dd4644
Compare
luepges
reviewed
Dec 1, 2025
| + " during the execution of the ${grammarname}Tool." | ||
| + System.lineSeparator() + "This error is unexpected" | ||
| + " and does not indicate an issue with any provided models.", | ||
| exception |
Contributor
There was a problem hiding this comment.
Das Ganze führt jetzt zu dem Unterschied, dass Errors in der Ausführung mit Exit Code 0 (aka "alles gut") beendet werden.
Wenn wir den Change schon machen -> Rückgabewert zu int Ändern und fail=1/okay=0 zurückgeben?
Contributor
Author
There was a problem hiding this comment.
Wie möchtest du den Rückgabewert von main ändern?
Ich würde System.exit eher vermeiden wollen, es sei denn, wir entfernen (lese: passen an) jeden Test, der zurzeit direkt die main Methode testet.
Contributor
Author
There was a problem hiding this comment.
Discussed in MC Weekly:
Add System.exit, change all the tests that call main to call run instead.
@luepges our gradle plugins should be fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.