feat: Minimize review when PR title is fixed #1014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
Owner
|
Hey, thanks for the PR! Plan to look at this over the weekend 🙏 |
Author
|
is there anything I can do to help you? |
Owner
Thank you for the offer! No I really just need to get down and actually spend some time on this, sorry! I do have it on my list and hope to soon 💀 In the meantime if you're blocked, I'd suggest using the fork for now. I'll ping in this thread when I finally get around to merging this! (On the other hand, maybe I need to get another maintainer here, so will think about that!) |
EBoisseauSierra
force-pushed
the
issue-1007/minimize-review-once-ok
branch
from
1f4c1fb to
659d29a
Compare
Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1007
This PR minimizes the review comment (if
on-failed-regex-create-review: true) once the regex succeeds. This prevents keeping an outdated (and possibly confusing) review in the PR timeline when it's no longer relevant.