Wip triggers

[mfpiccolo]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
motia-docs	Ready	Preview	Comment	Oct 5, 2025 4:12pm
motia-ui	Ready	Preview	Comment	Oct 5, 2025 4:12pm

[github-actions]

⚠️ This PR is quite large (>1000 lines). Consider splitting it into smaller PRs for easier review.

The best way to address this problem is to remove the unused variable declaration on line 131. Specifically, delete the line:

const originalCallStepFile = require('../call-step-file').callStepFile

No further code changes are needed, since this variable is not referenced anywhere afterwards. There are no dependencies to add, and this change does not affect logic or test integrity.

---

To fix this problem, remove the unused StepConfig import from the import statement on line 1. The best way to do this is to edit the import statement so that it imports only Step from '../types', eliminating StepConfig from the list. This change is isolated to the first line of the file and will not alter any existing functionality, as StepConfig is not referenced elsewhere in the shown code.

To fix this issue, simply remove Trigger from the named imports on line 2 of packages/core/src/helper/flows-helper.ts. No other code changes are required because Trigger is not referenced elsewhere in the file. Leave the rest of the import statement intact so Emit and Step remain imported.

---

To fix the issue, the unused imports hasApiTrigger, hasEventTrigger, and hasCronTrigger should be removed from the import statement on line 5 of packages/core/src/printer.ts. As none of these are used elsewhere in this code snippet, their removal will not alter the existing functionality of the codebase and will simply make the code cleaner and easier to maintain. No other code changes or new imports are needed.

To resolve the unused import, simply remove Event from the import statement on line 5. Leave the other imported types in place if they are still used. This change should be made within packages/core/src/state-trigger-handler.ts, editing only the relevant import line. No other changes are required, and there is no risk to program behavior, as removing an unused type import has no effect at runtime or for type checking.

To fix this problem, the unused variable should be removed from the destructuring assignment in the triggerStep function. Specifically, on line 242, filePath is destructured along with config, but it is never used. The function only uses config and its name property. The best fix is to change line 242 so that only the config property is destructured from step, leaving out filePath.

No further changes are required elsewhere, since nothing depends on the filePath variable in this context.

To fix the problem, we need to replace the use of Math.random() with a cryptographically secure random number generator. In Node.js, the recommended way is to use crypto.randomBytes from the built-in crypto module. We'll import crypto, generate a random set of bytes, and convert them to a string format suitable for use in a userId. The rest of the identifier can remain the same, using Date.now() for consistency, but the "random" part should come from cryptographically secure random bytes. Edit only the lines creating the userId (line 40) and add any necessary imports—do not change any other existing logic or interfaces.

---

To fix the issue, the unused variable declaration const consoleSpy = jest.spyOn(console, 'log').mockImplementation() on line 779 should be removed from the file playground/integration-tests/complexStateTriggers.spec.ts. This deletion is safe and will not affect test behavior, as its value is never used, nor its effects (mocking, restoring) invoked.

---

To fix the problem, simply remove the unused variable key from destructuring on line 19. Destructure just the needed properties from input — in this case value and traceId. No other code needs to change because the rest of the logic does not use key. The change is restricted to the destructuring line within the handler in playground/steps/complex-state-triggers/notification-cleaner.step.ts.

To fix the problem, simply remove the unused variable cleanupResult by either omitting the assignment altogether or, if the side effect of calling state.batch(...) is still required, call it as an expression and await its completion without assigning its result to any variable. Because only the assignment is flagged, and the function must still perform the atomic batch operation for notifications cleanup, the best fix is to call await state.batch(userId, cleanupOperations) without assigning its result to any variable. Only modify line 66 of playground/steps/complex-state-triggers/notification-cleaner.step.ts; no additional imports or definitions are required.

The most robust way to solve this issue is to use the tmp library to securely create a unique temporary file with proper permissions and guaranteed non-existence before creation. Replace the manual .tmp approach in _writeFile with tmp.fileSync() to generate the temp file for atomic writes. This change is localized to the _writeFile method in packages/core/src/state/adapters/default-state-adapter.ts. You need to:

• Add an import for the tmp package at the top of the file.
• Replace the logic in _writeFile so that it creates a secure temp file with tmp.fileSync(), writes the JSON data to that pathname, and then performs the atomic rename.
• Remember to clean up the temp file handle as well as the path if an error is thrown.
• No changes to tests are required.

---

To fix the problem, the file adapter should never create files or temporary files in the OS temp directory or in any location with a custom mechanism, unless steps are taken to guarantee atomicity, uniqueness, and proper permissions. Standard practice for securely writing temporary files is to use a well-tested library such as tmp. This library ensures temporary files are created with secure permissions, are unique, and are inaccessible to other users on the system.

To fix the current problem:

• Import the tmp library in default-state-adapter.ts.
• In the _writeFile method, instead of constructing tempPath manually, use tmp.fileSync() to get a securely created temporary file, and write your data to that.
• Atomically move/replace the file at the desired path.
• Remove the manual temp naming logic.
  Only replace relevant code and add the minimum imports required, staying inside the code you've been shown.

---