Skip to content

Conversation

@sidgaikwad
Copy link
Contributor

@sidgaikwad sidgaikwad commented Oct 7, 2025

PR: Make packages/core Build Cross-Platform

Description

This PR updates the packages/core build scripts to be cross-platform using rimraf and cpy-cli instead of Unix-specific commands.

Changes

  • Installed rimraf and cpy-cli as dev dependencies:
pnpm add -D rimraf cpy-cli
  • Updated packages/core/package.json scripts:
"scripts": {
  "python-setup": "python3 -m venv python_modules && python_modules/bin/pip install -r requirements.txt",
  "move:python": "cpy src/python/*.py dist/src/python --parents",
  "move:rb": "cpy src/ruby/*.rb dist/src/ruby --parents",
  "move:steps": "cpy src/steps/*.ts dist/src/steps --parents",
  "build": "rimraf dist && tsc && npm run move:python && npm run move:rb && npm run move:steps",
  "clean": "rimraf python_modules dist"
}

How to Test

  1. Run the build on Windows:
pnpm run build
  1. Verify that:

    • The dist folder is created correctly.
    • Python, Ruby, and step files are copied as expected.
    • No errors occur during build.

Screenshots:

image image

Fixes: #787

Notes

  • This change is fully cross-platform and works on Windows, macOS, Linux, and CI/CD pipelines.

@vercel
Copy link

vercel bot commented Oct 7, 2025

@sidgaikwad is attempting to deploy a commit to the motia Team on Vercel.

A member of the Team first needs to authorize it.

@ytallo ytallo force-pushed the Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd branch from 0baadc2 to 66132e8 Compare October 7, 2025 17:39
@github-actions github-actions bot added the size/M label Oct 7, 2025
@ytallo ytallo force-pushed the Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd branch from 66132e8 to 20b6de2 Compare October 7, 2025 17:51
@ytallo ytallo force-pushed the Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd branch from 20b6de2 to 33fdb36 Compare October 8, 2025 12:21
@sergiofilhowz
Copy link
Contributor

Thank you, I plan to test it later today on a windows machine

@sidgaikwad
Copy link
Contributor Author

Thank you, I plan to test it later today on a windows machine

yeah thanks

…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…-sidd' of https://github.com/sidgaikwad/motia into Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
@rohitg00
Copy link
Contributor

hey @sidgaikwad , Sergio is looking into this - sorry for some delay in this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Fails on Windows Due to Unix Shell Commands

3 participants