-
Notifications
You must be signed in to change notification settings - Fork 789
Fixes/build fails on windows due to unix shell commands sidd #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sidgaikwad
wants to merge
7
commits into
MotiaDev:main
Choose a base branch
from
sidgaikwad:Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes/build fails on windows due to unix shell commands sidd #788
sidgaikwad
wants to merge
7
commits into
MotiaDev:main
from
sidgaikwad:Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
+148
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
|
@sidgaikwad is attempting to deploy a commit to the motia Team on Vercel. A member of the Team first needs to authorize it. |
0baadc2 to
66132e8
Compare
66132e8 to
20b6de2
Compare
20b6de2 to
33fdb36
Compare
|
Thank you, I plan to test it later today on a windows machine |
yeah thanks |
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…-sidd' of https://github.com/sidgaikwad/motia into Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
|
hey @sidgaikwad , Sergio is looking into this - sorry for some delay in this review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Make
packages/coreBuild Cross-PlatformDescription
This PR updates the
packages/corebuild scripts to be cross-platform usingrimrafandcpy-cliinstead of Unix-specific commands.Changes
rimrafandcpy-clias dev dependencies:packages/core/package.jsonscripts:How to Test
Verify that:
distfolder is created correctly.Screenshots:
Fixes: #787
Notes