Generate singular values all ROIs in compute_SVD()
#128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I propose updating the singular value variables
S_movandS_motfrom 1-D numpy arrays to empty lists. The current implementation returns the singular values for only 1 ROI in the video whereas this update will allow the function to return the singular values for all ROIs in the video. The updated logic is similar toU_motandU_movvariables which contain the list of motion and movie SVDs, respectively for all ROIs in the video. These changes would resolve #107.There is also a minor fix for assigning the
savepathvariable in therun()function in this PR. This change would resolve #105.Please let me know if I need to address semantic versioning, provide further testing to ensure the code runs without issues, or produce any other changes that would be helpful.