[pull] master from dendronhq:master #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* fix: window path slash * make `normalizeUnixPath` the main function for its kind of purpose * embed slash library into our utils The rational is that the latest version of `slash` is build as a pure ES module which we currently don't support as a dependency. * update comment * replace `slash` with `normalize-path` To fit the purpose of `normalizeUnixPath` this commit switches to `normalize-path` which not only has the slash conversion but also path simplification and matches `path.posix.normalize` much closer.
…g for duplicate entries (#3719) * Fix deleted items being treated as notes * less verbose debug msg * rollback deleted check, skip src ctrl view, test
…ing go to note (#3769) * fix(workspace): correctly populate backlink when creating new note using go to note * chore: add comments
This uses `zod-validation-error` library to return a more readably validation message.
…n to (#3767) * fix: correctly handle block anchor updates during Move Selection To * fix: correctly handle same file links during update * chore: add test * chore: fix broken test
* fix(views): broken calendar view on theme toggle This commit just removes a default value for the `initialTheme` parameter inside the views util `getWebviewContent`. `genVSCodeHTMLIndex`, which is called with a forwarded `initialTheme`, has a codepath for an undefined `initialTheme` parameter. It means that no theme is going to override the default theme and therefore a certain ordering of css file references is taking place. So by always providing a default theme this codepath is never taken and results into a broken calendar view when toggling theme value. Removing that makes sure that the default theme is setup in way that keeps proper style ordering in place. That default theme was added as a solution for [[dendron://private/task.2022.05.31.fix-styling-for-plugin-views]] does not seam to be necessary for that. * chore(internal): fix invalid test-workspace note
* chore: fix `dendron-plugin-views` build This aim of this commit is to fix the build task within `dendron-plugin-views` package which currently results into the following error: ``` /home/nam/code/dendronhq/dendron/node_modules/zod-validation-error/node_modules/@swc/helpers/src/index.mjs Can't reexport the named export '__decorate' from non EcmaScript module (only default export is available) ``` The commit 419dec7 (PR: #3762) is responsible for this by adding a dependency which conflicts with the webpack build in `dendron-plugin-views`. That dependency uses withing its cjs build files `@swc/helpers` which conflicts with the import type from webpack. The solution is to use explicitly set [`Rule.type`](https://webpack.js.org/configuration/module/#ruletype) property which was introduced in [webpack 4.0](https://github.com/webpack/webpack/releases/tag/v4.0.0): > javascript/auto: (The default one in webpack 3) Javascript module with all module systems enabled: CommonJS, AMD, ESM > javascript/esm handles ESM more strictly compared to javascript/auto: > Imported names need to exist on imported module > Dynamic modules (non-esm, i. e. CommonJs) can only imported via default import, everything else (including namespace import) emit errors > In .mjs modules are javascript/esm by default In my understanding setting the value `javascript/auto` tells webpack that it allows for `mjs` files to be not ESM strict. This is a kind of hack and curcumvents the issue. In a proper setup `mjs` should only be handled as esm modules and nothing else. So instead of changing how webpack sees `mjs` file we might want to revert the change that introduced this issue. References - webpack/webpack#16213 (comment) * chore(internal): setup `dendron-plugin-views` build to prefer `main` entry field References - webpack/webpack#6459 (comment) - graphql/graphql-js#1272 (comment) - apollographql/apollo-link-state#302 (comment) * chore(internal): reverting to prevent increased bundle size Webpacks's treeshaking is negatively impacted by telling it to prefer `main` field instead of `module`. `module` point to esm modules which are what webpack needs to do its [treeshaking](https://webpack.js.org/guides/tree-shaking/). * chore(internal): pin version of `zod-validation-error` Intead of changing ``dendron-plugin-views` webpack build config this commits pins `zod-validation-error` to an older version within its dependency to `@swc/helpers` does not conflict with webpack rules.
* chore(internal): performance testing for engine methods * add env variables * spike: test performance workflow with github secrets * spike: fix typo and update timeout for ci * spike: add commitHash and branch to airtable * chore: revert performance workflow trigger * resolve PR comments * added rich formatting tests * spike: changed on condition in workflow for testing * revert ci conditions added for testing * add workflow to run perf on merge to master
…#3742) * fix(publish): displaying breadcrumb on sidebar hidden notes This commit aim's to make breadcumbs be shown when the note is hidden from the sidebar. This can happen with note properties like `has_collection` or `nav_exclude_children`. This is solved by moving that logic out of sidebar generator into tree-utils and the directly effected component (`DendronTreeMenu`). * chore: update test cases * chore(internal, e2e): expand visual regression tests for breadcrumb display * chore: revert `264b2e35c` The plan is the approach the issue from a different strategy. * Revert "chore: update test cases" This reverts commit 6fbf55a29e7e0e7cc3cb370bbe7ec766ef46b94a. * fix(publish): displaying breadcrumb on sidebar hidden notes
…ine v3 (#3781) * fix: correctly apply local override in engine v3 * fix: correctly handle absolute paths in global dendronrc.yml * chore: add test * chore: cleanup
* fix(workspace): rename note breaks noteref for user hierarchy * added comment
This reverts commit ec9561d.
Merge branch 'enhance/perf-mode' into release/0.124.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )