Skip to content

Conversation

@Bhoomi-18
Copy link

Pull Request Template

Summary

Added a menu page and linked the pages properly.

Fixes #475

Type of Change

Please mark [X] for applicable items:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Please describe the tests you performed to verify your changes:

Screenshots/Videos

Screenshot 2025-07-31 225653

Checklist

Please mark [X] for completed items:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coffee-shop ❌ Failed (Inspect) Aug 3, 2025 4:34pm

@github-actions
Copy link

Thank you for your contribution! 🎉

PR Checklist

  • Tests added/updated
  • Documentation updated
  • Changes follow coding standards
  • Commit messages are clear

Next Steps

  1. We will review your PR soon
  2. Address any requested changes
  3. Once approved, your PR will be merged

Need help? Check our Contributing Guide

Happy coding! 💻

@Mujtabaa07
Copy link
Owner

Screenshot 2025-08-01 075745 @Bhoomi-18 fix this

@Mujtabaa07 Mujtabaa07 requested a review from Copilot August 1, 2025 02:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a menu page to provide navigation to different product categories and fixes a typo in the soup page title.

  • Added a new Menu.js component with a card-based layout for navigating to different product categories
  • Corrected the title in the soup page from "Our Soupshake Selection" to "Our Soup Selection"
  • Updated routing in App.js to include the new menu page

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/Pages/Menu.js New menu page component with styled cards for Coffee, Cakes, Soups, and Milkshakes categories
src/Pages/soup.js Fixed typo in page title from "Soupshake" to "Soup"
src/App.js Added Menu import and route configuration, but contains duplicate code sections

Comment on lines +97 to +115
image: "https://img.freepik.com/free-photo/caramel-latte-with-chocolade-table_140725-4.jpg?t=st=1727759794~exp=1727763394~hmac=c764d48b2b28767da2c6b996ec20e0d6a5857c19724850db5e46498687e16225&w=740",
desc: "Explore our rich and aromatic coffee selection, from classic espresso to creamy lattes.",
link: "/menu/coffee"
},
{
title: "Cakes",
image: "https://img.freepik.com/free-photo/chocolate-cake_1203-8942.jpg?ga=GA1.1.900909129.1729318722&semt=ais_hybrid",
desc: "Indulge in our decadent cakes, perfect for every celebration and sweet craving.",
link: "/menu/cakes"
},
{
title: "Soups",
image: "https://img.freepik.com/free-photo/portrait-shooting-tomato-soup-with-crackers-cheese-tomatoes-bread-table_141793-2858.jpg?ga=GA1.1.900909129.1729318722&semt=ais_hybrid",
desc: "Warm up with our comforting soups, made with fresh ingredients and bold flavors.",
link: "/menu/soups"
},
{
title: "Milkshakes",
image: "https://www.sharmispassions.com/wp-content/uploads/2012/07/chocolate-milkshake1.jpg",
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image URL contains time-sensitive parameters (t=st=1727759794~exp=1727763394). These URLs may expire and break the images. Consider using permanent image URLs or hosting the images locally.

Suggested change
image: "https://img.freepik.com/free-photo/caramel-latte-with-chocolade-table_140725-4.jpg?t=st=1727759794~exp=1727763394~hmac=c764d48b2b28767da2c6b996ec20e0d6a5857c19724850db5e46498687e16225&w=740",
desc: "Explore our rich and aromatic coffee selection, from classic espresso to creamy lattes.",
link: "/menu/coffee"
},
{
title: "Cakes",
image: "https://img.freepik.com/free-photo/chocolate-cake_1203-8942.jpg?ga=GA1.1.900909129.1729318722&semt=ais_hybrid",
desc: "Indulge in our decadent cakes, perfect for every celebration and sweet craving.",
link: "/menu/cakes"
},
{
title: "Soups",
image: "https://img.freepik.com/free-photo/portrait-shooting-tomato-soup-with-crackers-cheese-tomatoes-bread-table_141793-2858.jpg?ga=GA1.1.900909129.1729318722&semt=ais_hybrid",
desc: "Warm up with our comforting soups, made with fresh ingredients and bold flavors.",
link: "/menu/soups"
},
{
title: "Milkshakes",
image: "https://www.sharmispassions.com/wp-content/uploads/2012/07/chocolate-milkshake1.jpg",
image: "/images/caramel-latte.jpg",
desc: "Explore our rich and aromatic coffee selection, from classic espresso to creamy lattes.",
link: "/menu/coffee"
},
{
title: "Cakes",
image: "/images/chocolate-cake.jpg",
desc: "Indulge in our decadent cakes, perfect for every celebration and sweet craving.",
link: "/menu/cakes"
},
{
title: "Soups",
image: "/images/tomato-soup.jpg",
desc: "Warm up with our comforting soups, made with fresh ingredients and bold flavors.",
link: "/menu/soups"
},
{
title: "Milkshakes",
image: "/images/chocolate-milkshake.jpg",

Copilot uses AI. Check for mistakes.
@Bhoomi-18
Copy link
Author

the error seema to be something at deployment which I can't actually debug as I don't have the logs. Gussesing from the screenshot it should be due to elements not wrapped in app.js but that's not the case. So please try to deploy it again. as I can't view the logs, I can't really do anything in that

@Mujtabaa07
Copy link
Owner

Mujtabaa07 commented Aug 2, 2025

the error seema to be something at deployment which I can't actually debug as I don't have the logs. Gussesing from the screenshot it should be due to elements not wrapped in app.js but that's not the case. So please try to deploy it again. as I can't view the logs, I can't really do anything in that

The error is not from the deployment side it's due to issues in the code itself. recheck your code thoroughly and resolve any issues before proceeding. Also, note that your code had conflicts even before deployment. Ensure that you're pushing to the correct branch and raise a PR without any conflicts first. Only after that should you proceed with raising pr.
react-scripts build
Creating an optimized production build...
Failed to compile.
[eslint]
src/App.js
Syntax error: Adjacent JSX elements must be wrapped in an enclosing tag. Did you want a JSX fragment <>...</>? (241:6) (241:6)
Error: Command "npm run build" exited with 1
Exiting build container
Check this, first run build, then check and then add a pr

@vercel
Copy link

vercel bot commented Aug 3, 2025

@Bhoomi-18 is attempting to deploy a commit to the mujtabaa07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Bhoomi-18
Copy link
Author

Bhoomi-18 commented Aug 3, 2025

Screenshot 2025-08-03 213830 Screenshot 2025-08-03 213904 this is now running fine please check it @Mujtabaa07

@Bhoomi-18
Copy link
Author

@Mujtabaa07 this has currently no conflicts. Please review the PR and merge it

@Bhoomi-18
Copy link
Author

@Mujtabaa07 please review the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add menu page

2 participants