Skip to content

NOISSUE Fix valid account check when starting instance #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JoelTroch
Copy link
Contributor

Thanks to phit on Discord for reporting the first issue and doing the initial investigation.

This PR fixes three issues:

  1. The "no accounts" message box no longer being displayed.
  2. In the "no accounts" message box, a missing space has been added and the "Mojang account" part has been removed since the whole migration thingy is over.
  3. And finally, if the user click the "Yes" button in the "no accounts" message box, they are properly redirected to the new/current "Accounts" dialog instead of the old one that no longer exists (the one in the "global settings" dialog).

About the fix for issue number 1: I tried a more "elegant fix" by getting rid of the "dummy" account that is created when MultiMC starts but I went into issues like crashes with an account is already set up. I'm not very familiar with MultiMC's codebase so I went with the hypothesis that this "dummy" account was "needed" and I went with the alternative that you see in this PR.

If this PR should have been divided into three distinct PRs, let me know and I'll split them.

Add a missing space and remove "Mojang account" since these are no longer
supported.
@JoelTroch JoelTroch changed the title NOISSUE Fix/valid account check when starting instance NOISSUE Fix valid account check when starting instance Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant