Expose parameter noiseStrength to user #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replaces the hard-coded value of c=10 with the parameter noiseStrength in simulator.noise(). 2. This parameter can now be set as a per-job setting specified by the user configuration file. 3. Adds a warning message if the parameter is encountered in the the config file and its value does not match the default, i.e. 10. 4. Update example-config.yaml with this option, but leave it commented out so people know that it is optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noiseStrength in simulator.noise().
by the user configuration file.
the config file and its value does not match the default, i.e. 10.
out so people know that it is optional.