forked from ccampbell/mousetrap
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add destroy method #1
Merged
misterdev
merged 1 commit into
Musixmatchdev:fix/mxm-add-destroy
from
misterdev:fix/mxm-add-destroy
Oct 20, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,6 +182,22 @@ | |
object.attachEvent('on' + type, callback); | ||
} | ||
|
||
/** | ||
* cross browser remove event method | ||
* | ||
* @param {Element|HTMLDocument} object | ||
* @param {string} type | ||
* @param {EventListenerOrEventListenerObject} callback | ||
* @returns void | ||
*/ | ||
function _removeEvent (object, type, callback) { | ||
if (object.removeEventListener) { | ||
object.removeEventListener(type, callback, false); | ||
return; | ||
} | ||
object.detachEvent('on' + type, callback); | ||
} | ||
|
||
/** | ||
* takes the event and returns the key character | ||
* | ||
|
@@ -707,13 +723,13 @@ | |
_ignoreNextKeypress = processedSequenceCallback && e.type == 'keydown'; | ||
}; | ||
|
||
/** | ||
/** | ||
* handles a keydown event | ||
* | ||
* @param {Event} e | ||
* @returns void | ||
*/ | ||
function _handleKeyEvent(e) { | ||
self._handleKeyEvent = function (e) { | ||
|
||
// normalize e.which for key events | ||
// @see http://stackoverflow.com/questions/4285627/javascript-keycode-vs-charcode-utter-confusion | ||
|
@@ -886,9 +902,9 @@ | |
}; | ||
|
||
// start! | ||
_addEvent(targetElement, 'keypress', _handleKeyEvent); | ||
_addEvent(targetElement, 'keydown', _handleKeyEvent); | ||
_addEvent(targetElement, 'keyup', _handleKeyEvent); | ||
_addEvent(targetElement, 'keypress', self._handleKeyEvent); | ||
_addEvent(targetElement, 'keydown', self._handleKeyEvent); | ||
_addEvent(targetElement, 'keyup', self._handleKeyEvent); | ||
Comment on lines
+905
to
+907
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is inside mousetrap constructor, I use |
||
} | ||
|
||
/** | ||
|
@@ -934,6 +950,29 @@ | |
return self.bind.call(self, keys, function() {}, action); | ||
}; | ||
|
||
/** | ||
* destroy mousetrap object | ||
* | ||
* - call reset on the mousetrap object ( removing all binding ) | ||
* - remove all javascript event listener from target element or document | ||
* - remove all reference to target | ||
* | ||
* @return void | ||
*/ | ||
|
||
Mousetrap.prototype.destroy = function () { | ||
var self = this | ||
|
||
self.reset() | ||
|
||
_removeEvent(self.target, 'keypress', self._handleKeyEvent); | ||
_removeEvent(self.target, 'keydown', self._handleKeyEvent); | ||
_removeEvent(self.target, 'keyup', self._handleKeyEvent); | ||
|
||
self.target = undefined | ||
self._handleKeyEvent = undefined | ||
} | ||
Comment on lines
+963
to
+974
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove the listeners and clear the instance |
||
|
||
/** | ||
* triggers an event that has already been bound | ||
* | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reverse of
_addEvent
that already exists