add support for arm64 builds for use on rpi #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
main
branch
19 times, most recently
from
c7c5080 to
934bde2
Compare
Comment on lines
+4
to
+5
| ARG TARGETARCH | ||
| ARG TRIPLET |
There was a problem hiding this comment.
these params need to be added to the docker-compose so we don't break the current build
There was a problem hiding this comment.
TARGETARCH is automatically supplied by Docker and TRIPLET is optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i wanted to be able to run this image on a raspberry pi cuz i'm cool like that and i make bad decisions. the original dockerfile only would pull in binaries for x86. this uses the
TARGETARCHbuild arg available in multi-platform builds to automatically pull in the x86 or arm build.i went ahead and pushed it to docker hub so others can use it that want it.
https://hub.docker.com/layers/w3irdrobot/mutinynet/latest/images/sha256-26ea93592f4c55a1ab296fc3d7ce2ea971d59dce903830ffb5495da2db81baca
not sure if this is even desired, but here it is anyways.