Skip to content

[CLEANUP] Split data provider for search pattern #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 19, 2025

A separate data provider now provides patterns which don't match any property names, and a separate test caters for the non-matching situation.

A separate data provider now provides patterns which don't match any property
names, and a separate test caters for the non-matching situation.
@JakeQZ JakeQZ requested a review from oliverklee June 19, 2025 17:28
@JakeQZ JakeQZ self-assigned this Jun 19, 2025
@JakeQZ JakeQZ added cleanup testing PRs/issues adding additional tests only, or primarily testing-focused labels Jun 19, 2025
@coveralls
Copy link

Coverage Status

coverage: 58.102%. remained the same
when pulling 5acc936 on cleanup/rulesettest-pattern
into 4f1fcf3 on main.

@oliverklee oliverklee merged commit 6a0c56d into main Jun 19, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/rulesettest-pattern branch June 19, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants