Skip to content

[BUGFIX] Provide the usual set of delimiters in parseValue tests #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[BUGFIX] Provide the usual set of delimiters in parseValue tests #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions tests/Value/ValueTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@
*/
final class ValueTest extends TestCase
{
/**
* the default set of delimiters for parsing most values
*
* @see \Rule\Rule::listDelimiterForRule
*
* @var array<int, string>
*/
private const DEFAULT_DELIMITERS = [',', ' ', '/'];

/**
* @return array<string, array{0: string}>
*/
Expand All @@ -39,7 +48,10 @@ function (string $unit): array {
*/
public function parsesArithmeticInFunctions(string $operator): void
{
$subject = Value::parseValue(new ParserState('max(300px, 50vh ' . $operator . ' 10px);', Settings::create()));
$subject = Value::parseValue(
new ParserState('max(300px, 50vh ' . $operator . ' 10px);', Settings::create()),
self::DEFAULT_DELIMITERS
);

self::assertSame('max(300px,50vh ' . $operator . ' 10px)', (string) $subject);
}
Expand Down Expand Up @@ -74,7 +86,10 @@ public function parsesArithmeticWithMultipleOperatorsInFunctions(
): void {
static $expression = '300px + 10% + 10vw';

$subject = Value::parseValue(new ParserState(\sprintf($parserTemplate, $expression), Settings::create()));
$subject = Value::parseValue(
new ParserState(\sprintf($parserTemplate, $expression), Settings::create()),
self::DEFAULT_DELIMITERS
);

self::assertSame(\sprintf($expectedResultTemplate, $expression), (string) $subject);
}
Expand All @@ -99,10 +114,10 @@ public static function provideMalformedLengthOperands(): array
*/
public function parsesArithmeticWithMalformedOperandsInFunctions(string $leftOperand, string $rightOperand): void
{
$subject = Value::parseValue(new ParserState(
'max(300px, ' . $leftOperand . ' + ' . $rightOperand . ');',
Settings::create()
));
$subject = Value::parseValue(
new ParserState('max(300px, ' . $leftOperand . ' + ' . $rightOperand . ');', Settings::create()),
self::DEFAULT_DELIMITERS
);

self::assertSame('max(300px,' . $leftOperand . ' + ' . $rightOperand . ')', (string) $subject);
}
Expand Down