Feat/devtooling 653 - Implementing whatsapp resource #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-genesyscloud into feat/DEVTOOLING-653
shrutisuryawanshigenesys
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12,
charliecon,
kavinbalagen,
BrianMoyles and
sureshperiyappan
as code owners
| */ | ||
|
|
||
| // dataSourceConversationsMessagingIntegrationsWhatsappRead retrieves by name the id in question | ||
| func dataSourceConversationsMessagingIntegrationsWhatsappRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { |
There was a problem hiding this comment.
pls enable caching for datasources too.
| name = "Test Integration Whatsapp" | ||
| embedded_signup_access_token = "test_token" | ||
| messaging_setting_id = genesyscloud_conversations_messaging_settings.settings.id | ||
| supported_content_id = genesyscloud_conversations_messaging_supportedcontent.content.id |
There was a problem hiding this comment.
can you add activate section as well in this example
| proxy := getConversationsMessagingIntegrationsWhatsappProxy(sdkConfig) | ||
|
|
||
| // Activate WhatsApp integration if requested, otherwise proceed with update | ||
| if activateWhatsapp := d.Get("activate_whatsapp").(*schema.Set); activateWhatsapp != nil { |
There was a problem hiding this comment.
if the user tries to make any other update.
this will always make an activate call of whatsapp, even if it is already activated
check for d.haschange of activate_whatsapp instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.