rpc-alt: redefine TransactionFilter #21203
Merged
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
56c96a5 to
66a1c18
Compare
amnn
force-pushed
the
amnn/rpc-tx-filter
branch
from
9cf9837 to
743b1a0
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
emmazzz
approved these changes
Feb 14, 2025
|
|
||
| #[serde_as] | ||
| #[derive(Clone, Debug, JsonSchema, Serialize, Deserialize)] | ||
| pub(crate) enum TransactionFilter { |
There was a problem hiding this comment.
What is the error that gets returned now if a user uses one of the unsupported filters from the OG filter enum? I suppose it will be rejected at the beginning (before even entering our code) with invalid params and a message like "wrong variant of enum"? Would like to make sure the message is clear.
There was a problem hiding this comment.
Yes, something like that -- here's an example:
{
"jsonrpc": "2.0",
"id": 1,
"error": {
"code": -32602,
"message": "Invalid params",
"data": "unknown variant `ToAddress`, expected one of `Checkpoint`, `MoveFunction`, `AffectedObject`, `FromAddress`, `FromAndToAddress`, `FromOrToAddress` at line 1 column 25"
}
}
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
66a1c18 to
242e956
Compare
amnn
force-pushed
the
amnn/rpc-tx-filter
branch
from
743b1a0 to
b2b6111
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-tx-filter
branch
from
b2b6111 to
eb6d686
Compare
amnn
force-pushed
the
amnn/rpc-tx-prune-test
branch
from
242e956 to
eb6d686
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than re-using the base JSON-RPC
TransactionFiltertype and having to respond that certain filters are unsupported, define our own compatible type which only contains the variants we do support. This way we will still return an invalid params error if someone tries to use an unsupported filter, but the filters we advertise in the schema will match what we can return a non-error response for.Test plan
Existing tests.
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.