Various estimator fixes #21298
Merged
Various estimator fixes #21298
+45
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mystenmark
commented
Feb 20, 2025
•
mystenmark
commented
- Use LruCache for local estimates
- Ensure estimator receive loop exigts at end of epoch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
force-pushed
the
mlogan-estimator-fixes
branch
from
59c3206 to
549d3e6
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
aschran
approved these changes
Feb 20, 2025
crates/sui-config/src/node.rs
Outdated
| /// | ||
| /// If unspecified, this will default to `10000`. | ||
| #[serde(default = "default_local_execution_time_lru_cache_size")] | ||
| pub local_execution_time_lru_cache_size: usize, |
There was a problem hiding this comment.
I would remove "LRU" from the names here, the type of cache isn't so important and who knows if we want to change it later
| @@ -74,16 +76,19 @@ impl ExecutionTimeObserver { | |||
| let mut observer = Self { | |||
| epoch_store: Arc::downgrade(epoch_store), | |||
| consensus_adapter, | |||
| local_observations: HashMap::new(), | |||
| local_observations: LruCache::new( | |||
| NonZero::new(lru_cache_size).expect("lru_cache_size must be non-zero"), | |||
There was a problem hiding this comment.
JMO: if you need it to always be nonzero here, the argument to ExecutionTimeObserver::spawn should take a NonZero
aschran
reviewed
Feb 20, 2025
| }; | ||
| tokio::spawn(async move { | ||
| let epoch_store = epoch_store.clone(); |
There was a problem hiding this comment.
I'd change the function arg here also to just be the by-value copy you need instead of taking a & and then cloning inside the function
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
force-pushed
the
mlogan-estimator-fixes
branch
from
cba62d2 to
2a9718f
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.