feat: add additive blob bucket support [6/n]#3213
Open
sadhansood wants to merge 2 commits intosadhan/05-sui-client-ptb-domain-splitfrom
Open
feat: add additive blob bucket support [6/n]#3213sadhansood wants to merge 2 commits intosadhan/05-sui-client-ptb-domain-splitfrom
sadhansood wants to merge 2 commits intosadhan/05-sui-client-ptb-domain-splitfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds additive blob bucket support to
walrus-suiwithout widening the existing owned blob APIs.It introduces bucket-specific Move bindings and Rust types for
BlobBucket,BlobBucketCap, andPooledBlob, plus new PTB and client methods for:The client resolves the blob bucket package from the bucket object itself, so bucket package/version handling stays local to the new bucket APIs instead of being pushed into the global contract config.
This PR also updates the local test publishing path to publish the
blob_bucketpackage, threads that package ID throughSystemContext, and adds an end-to-end bucket lifecycle test covering create, register, certify, extend, increase-capacity, and delete.Test plan
rustup run 1.86 cargo fmt -- --config group_imports=StdExternalCrate,imports_granularity=Crate,imports_layout=HorizontalVerticalcargo clippy --workspace --all-features --tests --no-deps -- -D warningscargo check -p walrus-sui --tests --all-featurescargo test -p walrus-sui --all-features test_blob_bucket_lifecycle -- --ignoredRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)