feat: add blob bucket backend [7/n]#3214
Open
sadhansood wants to merge 5 commits intosadhan/06-sui-blob-bucket-additive-supportfrom
Open
feat: add blob bucket backend [7/n]#3214sadhansood wants to merge 5 commits intosadhan/06-sui-blob-bucket-additive-supportfrom
sadhansood wants to merge 5 commits intosadhan/06-sui-blob-bucket-additive-supportfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an explicit blob bucket store path to
walrus-sdkbehind the internal store backend seam.The owned blob APIs stay unchanged. Instead, this PR adds a separate bucket backend and a new explicit SDK API for storing blobs into an existing bucket. The bucket path:
To support that cleanly, the internal store lifecycle now allows a backend-specific final result type, and the bucket flow gets its own
BlobBucketStoreResultplus bucket-specific post-registration states.This PR also exposes a public
blob_bucket_storage_pool_statushelper fromwalrus-suiso the SDK can size and extend buckets without reaching into private read-client internals.One intentional constraint in this PR: the bucket store path does not automatically retry the full operation across epoch changes. Pooled blob registration is not idempotent, so a full retry after partial success could create duplicate pooled blobs in the bucket.
Test plan
rustup run 1.86 cargo fmt -- --config group_imports=StdExternalCrate,imports_granularity=Crate,imports_layout=HorizontalVerticalcargo clippy --workspace --all-features --tests --no-deps -- -D warningscargo check -p walrus-sdkcargo check -p walrus-e2e-tests --testsI also added a new ignored e2e bucket test in
crates/walrus-e2e-tests/tests/test_client.rsRelease notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)