fix: Added unique node IDs, validator for worflow_plan, and unified planner model config#345
Open
rohit-sahoo wants to merge 3 commits intodevelopfrom
Open
fix: Added unique node IDs, validator for worflow_plan, and unified planner model config#345rohit-sahoo wants to merge 3 commits intodevelopfrom
rohit-sahoo wants to merge 3 commits intodevelopfrom
Conversation
… planner to GPT 5.2"
…or the PlannerConfig
rohit-sahoo
temporarily deployed
to
integration
GitHub Actions
Inactive
|
✅ Tests passed 📊 Test Results
Branch: 📋 Full coverage report and logs are available in the workflow run. |
NISH1001
requested changes
Feb 12, 2026
akd/planner/format_builder.py
Outdated
|
|
||
| type: str = Field(..., description="Node type corresponding to agent type") | ||
| id: str = Field(..., description="Unique node identifier (e.g., code_search_0, gap_analysis_0)") | ||
| type: str = Field(..., description="Node type corresponding to agent type for registry lookup") |
Collaborator
There was a problem hiding this comment.
Since type is built-in identifier, maybe switch to something like type_?
akd/planner/llm_planner.py
Outdated
| phase: ConversationPhase = Field(..., description="Current conversation phase") | ||
| question: Optional[PlannerQuestion] = Field(default=None, description="Follow-up question if needed") | ||
| question: PlannerQuestion | None = Field(default=None, description="Follow-up question if needed") | ||
| workflow_plan: Optional[WorkflowPlan] = Field(default=None, description="Generated workflow plan") |
Collaborator
There was a problem hiding this comment.
can you apply the new type hint style across all the planner modules? wehrever there's older style
|
✅ Tests passed 📊 Test Results
Branch: 📋 Full coverage report and logs are available in the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added unique node IDs to handle duplicate agents, added validator to ensure workflow_plan exists when ready_to_generate is true, and moved planner model config to single source in CONFIG for the planner.
Changes
1. Unique Node IDs (Duplicate Agents)
idfield toWorkflowNode(e.g.,code_search_1,code_search_2)idinstead oftypeid(e.g.,$.code_search_1.outputs.results)2. Model Config - Planner
planner_model_nametoModelConfigSettingsas single source of truthPlannerConfignow usesCONFIG.planner_model_nameFieldMappingGeneratornow usesCONFIG.planner_model_name3. Validators
ready_to_generate=Truerequiresworkflow_planto existHow to Test
Unit tests:
Manual test:
python scripts/demo_planner.py automated "Find weather repos, find climate repos, and do gap analysis"