Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gif generation notebook #163

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Update gif generation notebook #163

merged 3 commits into from
Aug 19, 2024

Conversation

smohiudd
Copy link
Collaborator

@smohiudd smohiudd commented Aug 16, 2024

The gif-generation notebook has a number of errors and will require updating (tracked in #121).

This PR:

  • updates the stac url to openveda.cloud
  • fixes a stac key error
  • Includes call out that the notebook is under review and will be updated with a new set up visualization libraries

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@smohiudd smohiudd marked this pull request as ready for review August 16, 2024 21:50
@smohiudd
Copy link
Collaborator Author

Getting an error importing selenium:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[48], line 3
      1 # for convenience we will wrap the API call from above into a method that will
      2 # save the contents of the image file into a file stored within the temp directory
----> 3 from gif_generation_dependencies.helper_functions import generate_frame
      5 # temporary directory to hold PNGs
      6 with tempfile.TemporaryDirectory() as tmpdirname:

File [~/veda-docs/notebooks/tutorials/gif_generation_dependencies/helper_functions.py:12](https://hub.openveda.cloud/user/smohiudd/lab/tree/veda-docs/notebooks/tutorials/veda-docs/notebooks/tutorials/gif_generation_dependencies/helper_functions.py#line=11)
      9 import rasterio
     10 import rasterio.features
---> 12 from selenium import webdriver
     13 from selenium.webdriver.chrome.service import Service as ChromeService
     14 from webdriver_manager.chrome import ChromeDriverManager

ModuleNotFoundError: No module named 'selenium'

Copy link

github-actions bot commented Aug 16, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-163/
on branch gh-pages at 2024-08-19 19:11 UTC

@smohiudd smohiudd changed the title Update of gif generation notebook Update gif generation notebook Aug 16, 2024
@jsignell
Copy link
Collaborator

ref #121

@smohiudd smohiudd merged commit 3638e7b into main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants